Skip to content

fix: all mcp protocol endpoints (/sse, /message, /mc... in sse.ts#3852

Closed
orbisai0security wants to merge 1 commit intomodelcontextprotocol:mainfrom
orbisai0security:fix-fix-v-004-sse-auth-middleware
Closed

fix: all mcp protocol endpoints (/sse, /message, /mc... in sse.ts#3852
orbisai0security wants to merge 1 commit intomodelcontextprotocol:mainfrom
orbisai0security:fix-fix-v-004-sse-auth-middleware

Conversation

@orbisai0security
Copy link
Copy Markdown

Summary

Fix critical severity security issue in src/everything/transports/sse.ts.

Vulnerability

Field Value
ID V-004
Severity CRITICAL
Scanner multi_agent_ai
Rule V-004
File src/everything/transports/sse.ts:26

Description: All MCP protocol endpoints (/sse, /message, /mcp) lack authentication middleware, allowing any network attacker to invoke MCP tools without proving their identity. While OAuth mechanisms exist in the codebase, there is no evidence of enforcement on these critical endpoints that handle filesystem operations, knowledge graph modifications, and fetch requests.

Changes

  • src/everything/transports/sse.ts

Verification

  • Build passes
  • Scanner re-scan confirms fix
  • LLM code review passed

Automated security fix by OrbisAI Security

Automated security fix generated by Orbis Security AI
@olaservo
Copy link
Copy Markdown
Member

Thanks, but closing this. The everything server is a reference/demo implementation — authentication on transports is intentionally left to the deployer per the MCP authorization spec, which delegates auth to the transport layer. Adding hardcoded middleware here would obscure the reference behavior we want users to learn from. Automated scanner findings against reference servers don't generally indicate real vulnerabilities; they should be evaluated in the context of the server's purpose. If you believe there's a real spec-level concern, please open an issue with details first so it can be discussed.

@olaservo olaservo closed this Apr 18, 2026
@orbisai0security
Copy link
Copy Markdown
Author

Totally fair, thanks for the context. I agree that the everything server is a reference/demo, and auth should be handled by the deployer at the transport layer per the spec, so hardcoding middleware here would be misleading. I’ll treat the scanner hit as informational and, if it’s useful, open an issue proposing a prominent docs note/example for how to front these endpoints with auth in real deployments.

@cliffhall cliffhall added bug Something isn't working server-everything Reference implementation for the Everything MCP server - src/everything labels Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working server-everything Reference implementation for the Everything MCP server - src/everything

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants